Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fallback for functools.wraps #771

Merged
merged 1 commit into from Nov 28, 2011
Merged

Remove fallback for functools.wraps #771

merged 1 commit into from Nov 28, 2011

Conversation

steveanton
Copy link
Contributor

Since functools.wraps is included in the default distribution of Python as of version 2.5, there is no need to provide a fallback.

See:
http://www.google-melange.com/gci/task/view/google/gci2011/7184247

http://code.google.com/p/sympy/issues/detail?id=2873

@goodok
Copy link
Contributor

goodok commented Nov 28, 2011

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9ZQGDA

Interpreter: /usr/bin/python (2.5.5-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 0803e19
branch hash: 27794a9
XPassed tests: 2

Summary: All tests have passed.

Automatic review by sympy-bot.

@goodok
Copy link
Contributor

goodok commented Nov 28, 2011

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYvdYFDA

Interpreter: /usr/bin/python (3.2.2-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 0803e19
branch hash: 27794a9

Summary: There were test failures.

@Anxuiz: Please fix the test failures.

Automatic review by sympy-bot.

@goodok
Copy link
Contributor

goodok commented Nov 28, 2011

@Anxuiz: please ignore the previous comment of test failures for python3.

For others:
Test failures for Python3 are related only with the master ones. See PR 770.

@goodok
Copy link
Contributor

goodok commented Nov 28, 2011

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY3ZwGDA

Interpreter: /usr/bin/python (2.6.6-final-0)
Architecture: Linux (32-bit)
Cache: yes
Test command: setup.py test
master hash: 0803e19
branch hash: 27794a9
XPassed tests: 4

Summary: All tests have passed.

Automatic review by sympy-bot.

@goodok
Copy link
Contributor

goodok commented Nov 28, 2011

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY3pwGDA

Interpreter: /usr/bin/python (2.7.2-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 0803e19
branch hash: 27794a9
XPassed tests: 2

Summary: All tests have passed.

Automatic review by sympy-bot.

goodok added a commit that referenced this pull request Nov 28, 2011
@goodok
Merge pull request #771 from Anxuiz/decorators-functools-wraps
dba5c30 
Remove fallback for functools.wraps
@goodok goodok merged commit dba5c30 into sympy:master Nov 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steveanton @goodok